Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hdfsprotocol WriteTo #943

Closed
wants to merge 1 commit into from
Closed

fix: hdfsprotocol WriteTo #943

wants to merge 1 commit into from

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 17, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner December 17, 2021 04:32
@jim3ma jim3ma changed the title fix: hdfsprotocol WritoTo fix: hdfsprotocol WriteTo Dec 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #943 (972054a) into main (9bf050c) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   42.62%   42.56%   -0.07%     
==========================================
  Files         115      115              
  Lines        8708     8703       -5     
==========================================
- Hits         3712     3704       -8     
- Misses       4529     4532       +3     
  Partials      467      467              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.56% <75.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/source/hdfsprotocol/hdfs_source_client.go 51.85% <75.00%> (+1.40%) ⬆️
cdn/supervisor/progress/progress.go 91.04% <0.00%> (-5.98%) ⬇️
client/daemon/peer/peertask_base.go 45.96% <0.00%> (-0.58%) ⬇️

@jim3ma jim3ma closed this Dec 17, 2021
@gaius-qi gaius-qi deleted the fix/hdfsprotocol branch March 9, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants