Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client sync send unsafe call #1240

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: client sync send unsafe call #1240

merged 2 commits into from
Apr 11, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 11, 2022 •
edited
Loading

Signed-off-by: Jim Ma [email protected]

Description

It is not safe to call SendMsg on the same stream in different goroutines at the same time.
Refer: https://github.com/grpc/grpc-go/blob/master/stream.go#L1405

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner April 11, 2022 08:25
gaius-qi
gaius-qi approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d35278f into main Apr 11, 2022
@gaius-qi gaius-qi deleted the fix/client-sync-send-unsafe-call branch April 11, 2022 13:10
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
fix: client sync send unsafe call (#1240)
41d5ee6 
* fix: client sync send unsafe call

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@244372610 244372610 244372610 approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim3ma @gaius-qi @244372610