fix: sync pieces hang

[jim3ma]

Signed-off-by: Jim Ma [email protected]

Description

For legacy peers, when call SyncPieceTasks, we must receive at least one piece tasks.

If scheduler :

1. send to peer A with peer packet, main peer: peer x, steal peers: B
2. send to peer B with peer packet, main peer: peer x, steal peers: A

Both of peer A and peer B do not have any pieces, they will hang at receiving the first piece tasks.

So we need send an empty piece tasks to each others to avoid this hang bug.

Related Issue

Fix #1220

Motivation and Context

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation Update (if none of the other choices apply)

Checklist

• Code compiles correctly.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

Merging #1221 (b0c7ca8) into main (bdca38b) will increase coverage by 0.35%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   46.05%   46.40%   +0.35%     
==========================================
  Files         133      133              
  Lines       10566    10568       +2     
==========================================
+ Hits         4866     4904      +38     
+ Misses       5154     5107      -47     
- Partials      546      557      +11     

Flag	Coverage Δ
Object-compatibility-e2etests	?
e2etests	?
unittests	46.40% <71.42%> (+0.35%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
client/daemon/rpcserver/rpcserver.go	37.90% <66.66%> (-0.25%)	⬇️
client/daemon/rpcserver/subscriber.go	47.82% <66.66%> (-1.74%)	⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go	47.27% <100.00%> (+0.32%)	⬆️
client/daemon/peer/piece_broker.go	89.74% <0.00%> (-2.57%)	⬇️
client/daemon/peer/peertask_conductor.go	57.18% <0.00%> (+0.98%)	⬆️
client/daemon/peer/peertask_piecetask_poller.go	53.33% <0.00%> (+22.96%)	⬆️

[gaius-qi]

LGTM