Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client miss failed piece #1194

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix: client miss failed piece #1194

merged 1 commit into from
Mar 25, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 25, 2022

Signed-off-by: Jim Ma [email protected]

Description

In waitFailedPiece we receive a failed piece, then pullPiecesFromPeers loop go on and wait the failedPieceCh again,
if two failed piece sent to failedPieceCh, the first piece is missed.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner March 25, 2022 06:59
@codecov-commenter
Copy link

Codecov Report

Merging #1194 (e02ba9f) into main (c6c05f6) will decrease coverage by 0.03%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   46.49%   46.46%   -0.04%     
==========================================
  Files         133      133              
  Lines       10513    10523      +10     
==========================================
+ Hits         4888     4889       +1     
- Misses       5070     5079       +9     
  Partials      555      555              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.46% <18.18%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 57.69% <18.18%> (-0.54%) ⬇️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit 7e5860e into main Mar 25, 2022
@244372610 244372610 deleted the fix/client-miss-failed-piece branch March 25, 2022 07:20
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants