Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace time.Now().Sub by time.Since #1173

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Mar 22, 2022

Signed-off-by: yxxhero [email protected]

Description

replace time.Now().Sub by time.Since

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yxxhero yxxhero requested a review from a team as a code owner March 22, 2022 08:00
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1173 (abbe645) into main (612905f) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   46.24%   46.28%   +0.03%     
==========================================
  Files         132      132              
  Lines       10241    10241              
==========================================
+ Hits         4736     4740       +4     
+ Misses       4962     4958       -4     
  Partials      543      543              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.28% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/storage/storage_manager.go 17.86% <0.00%> (ø)
client/dfget/dfget.go 13.18% <50.00%> (ø)
client/daemon/peer/peertask_conductor.go 57.36% <100.00%> (+0.35%) ⬆️
client/daemon/peer/peertask_reuse.go 84.04% <100.00%> (ø)
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+3.70%) ⬆️

@gaius-qi gaius-qi merged commit 23ae03f into dragonflyoss:main Mar 22, 2022
@yxxhero yxxhero deleted the replace_time branch March 22, 2022 08:32
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants