Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty client output path #1159

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Fix empty client output path #1159

merged 3 commits into from
Mar 16, 2022

Conversation

244372610
Copy link
Contributor

Signed-off-by: sunwp [email protected]

Description

If the client output parameter is not specified, the client cannot automatically obtain the target file path

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…tomatically obtain the target file path

Signed-off-by: sunwp <[email protected]>
@244372610 244372610 requested a review from a team as a code owner March 14, 2022 08:28
@244372610 244372610 requested review from imeoer, jim3ma and hyy0322 March 14, 2022 08:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1159 (6c3ae6b) into main (9155d1b) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
+ Coverage   46.00%   46.05%   +0.05%     
==========================================
  Files         130      130              
  Lines       10045    10042       -3     
==========================================
+ Hits         4621     4625       +4     
+ Misses       4900     4893       -7     
  Partials      524      524              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.05% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dfget.go 21.62% <ø> (+0.84%) ⬆️
cdn/supervisor/progress/progress.go 96.87% <0.00%> (+6.25%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit b53cbda into main Mar 16, 2022
@gaius-qi gaius-qi deleted the bugfix/clientOutPath branch March 16, 2022 09:48
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* If the client output parameter is not specified, the client cannot automatically obtain the target file path

Signed-off-by: sunwp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants