Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemon scheduler option validate bug #1152

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

244372610
Copy link
Contributor

Signed-off-by: sunwp [email protected]

Description

fix daemon scheduler option validate bug

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner March 11, 2022 02:29
@codecov-commenter
Copy link

Codecov Report

Merging #1152 (ae88883) into main (ee14ede) will increase coverage by 0.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   45.57%   45.95%   +0.37%     
==========================================
  Files         130      130              
  Lines       10042    10045       +3     
==========================================
+ Hits         4577     4616      +39     
+ Misses       4952     4905      -47     
- Partials      513      524      +11     
Flag Coverage Δ
unittests 45.95% <0.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 35.15% <0.00%> (-0.14%) ⬇️
scheduler/resource/cdn.go 62.29% <0.00%> (ø)
scheduler/service/service.go 86.95% <0.00%> (+0.03%) ⬆️
scheduler/resource/peer.go 77.84% <0.00%> (+0.14%) ⬆️
client/daemon/peer/peertask_conductor.go 57.57% <0.00%> (+0.72%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 50.34% <0.00%> (+21.37%) ⬆️

Copy link
Member

@KubeStacker KubeStacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3b39cea into main Mar 11, 2022
@gaius-qi gaius-qi deleted the bugfix/clientManagerOption branch March 11, 2022 02:47
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants