Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler metrics add default value of biz tag #1151

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Scheduler metrics add default value of biz tag.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 10, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 10, 2022 03:33
@gaius-qi gaius-qi self-assigned this Mar 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1151 (0a717a0) into main (435e539) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   45.99%   45.95%   -0.04%     
==========================================
  Files         130      130              
  Lines       10043    10044       +1     
==========================================
- Hits         4619     4616       -3     
- Misses       4900     4904       +4     
  Partials      524      524              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.95% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/cdn.go 62.29% <0.00%> (ø)
scheduler/resource/peer.go 77.84% <100.00%> (+0.14%) ⬆️
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️

Copy link

@qwtsc qwtsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@qwtsc qwtsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 843b800 into main Mar 10, 2022
@gaius-qi gaius-qi deleted the feature/default-biz-tag branch March 10, 2022 07:30
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants