Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: when peer downloads finished, peer deletes parent #1116

Merged
merged 1 commit into from
Mar 2, 2022
Merged

feat: when peer downloads finished, peer deletes parent #1116

merged 1 commit into from
Mar 2, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Mar 2, 2022

Signed-off-by: Gaius [email protected]

Description

  • When peer downloads finished, peer deletes parent

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 2, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 2, 2022 10:39
@gaius-qi gaius-qi self-assigned this Mar 2, 2022
jim3ma
jim3ma approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit d7ab722 into main Mar 2, 2022
@jim3ma jim3ma deleted the feature/scheduler-remove-parent branch March 2, 2022 12:50
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: when peer downloads finished, peer deletes parent (#1116)
8ba4a12 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyy0322 hyy0322 hyy0322 approved these changes

@jim3ma jim3ma jim3ma approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
scheduler
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gaius-qi @jim3ma @hyy0322