Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize reuse logic #1110

Merged
merged 3 commits into from
Mar 2, 2022
Merged

chore: optimize reuse logic #1110

merged 3 commits into from
Mar 2, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 2, 2022

Signed-off-by: Jim Ma [email protected]

Description

  1. rename rg to reuseRange to clarify purpose.
  2. add missing Content-Range header for reusing subtasks.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner March 2, 2022 02:38
@codecov-commenter
Copy link

Codecov Report

Merging #1110 (fef2684) into main (1fede26) will decrease coverage by 0.01%.
The diff coverage is 48.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   45.31%   45.30%   -0.02%     
==========================================
  Files         130      130              
  Lines        9959     9969      +10     
==========================================
+ Hits         4513     4516       +3     
- Misses       4920     4927       +7     
  Partials      526      526              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.30% <48.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_reuse.go 51.53% <48.71%> (-2.07%) ⬇️
client/daemon/peer/peertask_conductor.go 57.31% <0.00%> (ø)
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+3.70%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 84b8bcd into main Mar 2, 2022
@gaius-qi gaius-qi deleted the chore/optimize-reuse-logic branch March 2, 2022 08:07
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* chore: optimize reuse logic

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants