Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stream send error code #986

Merged
merged 14 commits into from
Jan 17, 2022
Merged

feat: stream send error code #986

merged 14 commits into from
Jan 17, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jan 12, 2022 •
edited
Loading

Description

  • Scheduler stream send error code to dfdaemon.
  • Fix tree loop.
  • Report piece before close stream.
  • Update helm charts version.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Jan 12, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner January 12, 2022 13:53
@gaius-qi gaius-qi self-assigned this Jan 12, 2022
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch from 65bd8bb to e087dd2 Compare January 13, 2022 10:12
@gaius-qi
test: callback
2b2ff25 
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch from e087dd2 to 2b2ff25 Compare January 13, 2022 10:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022 •
edited
Loading

Codecov Report

Merging #986 (946b3fe) into main (55350fe) will decrease coverage by 0.27%.
The diff coverage is 61.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   46.08%   45.80%   -0.28%     
==========================================
  Files         130      130              
  Lines        9092     9130      +38     
==========================================
- Hits         4190     4182       -8     
- Misses       4435     4477      +42     
- Partials      467      471       +4
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.80% <61.66%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
scheduler/service/callback.go 67.30% <41.17%> (-11.39%) ⬇️
scheduler/resource/peer.go 74.35% <65.38%> (-5.65%) ⬇️
scheduler/rpcserver/rpcserver.go 93.23% <75.00%> (-3.10%) ⬇️
client/daemon/peer/peertask_conductor.go 57.09% <100.00%> (ø)
client/daemon/peer/piece_manager.go 66.78% <100.00%> (+0.12%) ⬆️
scheduler/scheduler/evaluator/evaluator_base.go 91.93% <100.00%> (+0.41%) ⬆️
scheduler/scheduler/scheduler.go 86.41% <100.00%> (+0.89%) ⬆️
scheduler/service/service.go 92.94% <100.00%> (-4.65%) ⬇️
cdn/supervisor/progress/progress.go 91.04% <0.00%> (-5.98%) ⬇️
... and 3 more

@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch 9 times, most recently from 18c132a to 363b100 Compare January 14, 2022 09:18
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch from 363b100 to 50f3b83 Compare January 14, 2022 10:02
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch from 50f3b83 to 025d58d Compare January 14, 2022 10:12
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch 11 times, most recently from 4458204 to 4ff4d68 Compare January 17, 2022 08:21
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch 2 times, most recently from a3319c0 to 01187ca Compare January 17, 2022 08:52
@gaius-qi gaius-qi force-pushed the feature/stream-send-error-code branch from 01187ca to 946b3fe Compare January 17, 2022 09:53
jim3ma
jim3ma approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit bec343a into main Jan 17, 2022
@gaius-qi gaius-qi deleted the feature/stream-send-error-code branch January 17, 2022 11:35
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: stream send error code (#986)
5479b3a 
* feat: change task and peer ttl (#984)

Signed-off-by: Gaius <[email protected]>

* feat: send error code

Signed-off-by: Gaius <[email protected]>

Signed-off-by: Gaius <[email protected]>

* feat: add retry interval

Signed-off-by: Gaius <[email protected]>

* feat: dfdaemon report successful piece before end of piece

Signed-off-by: Gaius <[email protected]>

* feat: update submodule version

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@244372610 244372610 244372610 approved these changes

@jim3ma jim3ma jim3ma approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
scheduler
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@gaius-qi @codecov-commenter @jim3ma @244372610