Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster_mgr.py #2855

Closed
chakaz opened this issue Apr 7, 2024 · 5 comments
Closed

Fix cluster_mgr.py #2855

chakaz opened this issue Apr 7, 2024 · 5 comments

Comments

@chakaz
Copy link
Collaborator

chakaz commented Apr 7, 2024

No description provided.

@chakaz chakaz added this to the dfly cluster v2 milestone Apr 7, 2024
@nicks64
Copy link

nicks64 commented Apr 15, 2024

could you share some detail or description of what went wrong?

@chakaz
Copy link
Collaborator Author

chakaz commented Apr 16, 2024

We've made some changes to the management commands, and haven't yet updated cluster_mgr.py to use them.

@nicks64
Copy link

nicks64 commented Apr 16, 2024

where are the management commands? do you mind sharing what i can do to contribute?

also feel free to share the changes you made. Thank you!

@chakaz
Copy link
Collaborator Author

chakaz commented Apr 16, 2024

First, thanks for your good intentions :)
This is one of the internal tasks that are probably best to be implemented by the core team. There are some moving parts and decisions that we haven't yet even documented.
However, if you are looking to contribute, please feel free to look at our "good first issue" label or "help wanted" label.
Thanks!

@chakaz
Copy link
Collaborator Author

chakaz commented Jun 5, 2024

With #3118, #3120, #3124, and #3129 (which adds tests, and will be merged soon)
This task is now finished :)

@chakaz chakaz closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants