Fix colors to properly match palette #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pushed up some fixes to Tinted-Theming as well... It supports base16, and more colors for ANSI. Mind having a look? tinted-theming/schemes#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the mismatched colors and also makes the theme fit more in line with the original Dracula palette. The current palette as is can cause some serious color clashing when using anything to apply the base16 colors across applications like Firefox. This change actually makes it more inline to what the Dracula Kitty theme looks like. Fixes #10 and #13. The palette is @pcewing's idea!
Note: While yes, some programs like Kitty still look a bit weird because they require more colors; but for those edge cases, one can just use the theme for that specific application. But just changing up the palette makes it match way more inline with the official theme palette.
Screenshots below show what the original and corrected schemes look like on Kitty terminal with
msgcat --color=testand Firefox onNixOS, 24.05 (Uakari), 24.05.20240322.649ccce. The tool I used to apply the theme is stylixOriginal Scheme
Corrected Scheme
