Add BrokerConnection.connect_blocking() #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2018
|
How to handle this when I am trying to consume on my mac? Seeing the issue and when I add the api version I don't get any results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a blocking connect to BrokerConnection that will attempt to connect to all ip/ports found via a single dns lookup. We can use this during bootstrap and version probes to handle brokers that advertise a hostname that has multiple interfaces but the broker only listens on one of them. This can happen when a host has both an IPv4 and an IPv6 interface (but the kafka broker binds to only one of them). This will also help in contexts where the bootstrap_servers list includes a multi-address dns entry where not all results are available/healthy.