Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure indicating legit problem #1846

Closed
jeffwidman opened this issue Jun 20, 2019 · 5 comments
Closed

test failure indicating legit problem #1846

jeffwidman opened this issue Jun 20, 2019 · 5 comments

Comments

@jeffwidman
Copy link
Collaborator

https://travis-ci.org/dpkp/kafka-python/jobs/547927009

This appears to be a legit bug of some sort, unrelated to the actual PR. Dinnertime, so I don't have time to investigate so creating this ticket so I don't lose track of it.

cc @Baisang any ideas? Since you wrote this test, although my hunch is that the failure is unrelated to the test itself...

@jeffwidman
Copy link
Collaborator Author

Shoot, looks like restarting the job didn't create a new one, but instead overwrote the old one... my bad.

The reported problem was that a topic the test expected to exist wasn't returned by topics().

@Baisang
Copy link
Contributor

Baisang commented Jun 20, 2019

Was this introduced as part of #1845 ? maybe we just forgot to wait for a future in there or something.

@Baisang
Copy link
Contributor

Baisang commented Jun 20, 2019

For reference, the test in question was introduced in #1829

@jeffwidman
Copy link
Collaborator Author

I'd considered that, except that PR #1845 only touches the KafkaAdminClient which is currently completely untested... (I'm planning to add tests for it once #1193 is complete as that will greatly simplify the test harness.)

So it wouldn't have affected it at all...

I'm guessing it was some sort of race condition that rarely manifests, and I suspect the problem is in core, not in the test.

@jeffwidman
Copy link
Collaborator Author

Closing as unable to replicate for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants