Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #412 #1195

Closed
wants to merge 3 commits into from
Closed

Fix #412 #1195

wants to merge 3 commits into from

Conversation

maltoze
Copy link

@maltoze maltoze commented Nov 22, 2019

Currently, after a user login with AUTH_DB not redirect to intent url.
This will fix it.

related:
#412
apache/superset#1303

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@625725c). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1195   +/-   ##
=========================================
  Coverage          ?   71.65%           
=========================================
  Files             ?       44           
  Lines             ?     6004           
  Branches          ?        0           
=========================================
  Hits              ?     4302           
  Misses            ?     1702           
  Partials          ?        0
Impacted Files Coverage Δ
flask_appbuilder/security/views.py 54.51% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625725c...1e768c2. Read the comment docs.

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! can you please add the same logic on AuthLDAPView ?

@maltoze maltoze closed this Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants