Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors.xml gets overwritten by firebasex if there is only one color in it #284

Closed
RaederDev opened this issue Jan 22, 2020 · 0 comments
Closed
Labels
android Relates to Android platform bug Something isn't working properly

Comments

@RaederDev
Copy link

I have a custom colors.xml with one color in it in order to use the new adaptive icons feature that cordova provides:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="background">#000000</color>
</resources>

This gets overwritten by firebasex like so:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="accent">#FF00FFFF</color>
</resources>

However when I add a second (useless) color to my configuration firebasex merged the config like it should:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="background">#000000</color>
    <color name="background_blk">#000000</color>
</resources>

After build:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <color name="background">#000000</color>
    <color name="background_blk">#000000</color>
    <color name="accent">#FF00FFFF</color>
</resources>

It would be good if it also works with only one color since that's what the cordova documentation shows for adaptive icons.

@dpa99c dpa99c added android Relates to Android platform bug Something isn't working properly labels Feb 19, 2020
@dpa99c dpa99c closed this as completed in 69565d1 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to Android platform bug Something isn't working properly
Projects
None yet
Development

No branches or pull requests

2 participants