Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support more Firebase Authentication operations #208

Closed
dpa99c opened this issue Nov 4, 2019 · 16 comments
Closed

[FEATURE] Support more Firebase Authentication operations #208

dpa99c opened this issue Nov 4, 2019 · 16 comments
Labels
android Relates to Android platform feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform wontfix

Comments

@dpa99c
Copy link
Owner

dpa99c commented Nov 4, 2019

Currently the plugin only exposes phone auth functionality for iOS & Android via verifyPhoneNumber() however there are multiple other useful Firebase SDK auth API functions to manage users and sign in users in other ways.

So we should expose these, which will make verifyPhoneNumber() in itself more useful

@dpa99c dpa99c added android Relates to Android platform feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform labels Nov 4, 2019
@mfkenson
Copy link

mfkenson commented Nov 7, 2019

@dpa99c any chance verifyPhoneNumber will be available on cordova browser platform?

@dpa99c
Copy link
Owner Author

dpa99c commented Nov 7, 2019

@mfkenson there is no plan to add browser platform support to this plugin

@svzi
Copy link

svzi commented Nov 18, 2019

What about my closed issue regarding the Apple Authentication provider? It's mandatory for all new iOS apps, that implement other auth providers. And it will be mandatory for existing apps, in the spring of 2020 as far as I know.

I'm currently working for a client who will release his app on iOS very soon. He already has auth via Facebook and Google implemented. Because this is a new app, the chance are heigh that Apple will reject App Store submission, because of missing auth with Apple.

Do you have any plans to add Apple in the very near future?

@svzi
Copy link

svzi commented Nov 22, 2019

The first apps got already rejected because of a missing "Login with Apple" button:
firebase/firebase-ios-sdk#3145 (comment)

@dpa99c
Copy link
Owner Author

dpa99c commented Nov 22, 2019

When I have time, I will update the Firebase SDK and implement Apple Sign In, though I can't promise that will be soon as I'm busy with other stuff and I don't use this functionality myself.
I will also accept a PR that implements it and push that out in a patch release.

@svzi
Copy link

svzi commented Feb 11, 2020

@dpa99c Any update here?

@dpa99c
Copy link
Owner Author

dpa99c commented Feb 12, 2020

@svzi please see the dev branch of this repo where I have been working on this time-permitting and the corresponding dev branch of the example project.
I have many other commitments (I have spread myself across to many open source projects) so I will get around to doing more on this as and when I have time.

@dpa99c
Copy link
Owner Author

dpa99c commented Feb 18, 2020

The new authentication functionality has now been released in [email protected].
Please test using the master branch of the example project.

@dpa99c
Copy link
Owner Author

dpa99c commented Feb 19, 2020

Example of new auth functionality: Sign In with Apple in the example app on iOS and Android

@mavericardo
Copy link

Do you have a example with ionic 4?

This method authenticateUserWithApple not exist in @ionic-native/firebase-x, you can help me in this problem?

I have to deliver this as soon as possible :(

Screen Shot 2020-03-10 at 11 54 44

Screen Shot 2020-03-10 at 11 54 48

Screen Shot 2020-03-10 at 11 54 55

@svzi
Copy link

svzi commented Mar 10, 2020

@marcosricardo My advize: get rid of @ionic-native/firebase-x and just use this plugin. I didn't check, but it looks like the Ionic-Wrapper isn't up to date with the latest version of this plugin.

@dpa99c
Copy link
Owner Author

dpa99c commented Mar 10, 2020

@marcosricardo The ionic-native/firebase-x wrapper is maintained by Ionic so raise an issue or make a PR to the ionic-native repo to add support for any missing API functions.

or call the plugin's JS API directly, e.g.:

(<any>window).FirebasePlugin.authenticateUserWithApple(credential => console.dir(credential), error => console.error(error))

@mavericardo
Copy link

mavericardo commented Mar 10, 2020

Ok, I'm almost there.

Log in XCODE.

Screen Shot 2020-03-10 at 17 21 05

Screen Shot 2020-03-10 at 17 21 10

created my user in console firebase but not return success

Screen Shot 2020-03-10 at 18 22 14

I have only one problem now.

signInWithCredential return null.

I activated sign with apple in console firebase and apple developer - APP ID but not working.

Thanks.

@dpa99c
Copy link
Owner Author

dpa99c commented Mar 11, 2020

@marcosricardo please see the example project for a working example.

@vdias38
Copy link

vdias38 commented Jun 17, 2020

I've submitted a PR danielsogl/awesome-cordova-plugins#3458 to add all missing plugin functions, incl. authenticateUserWithApple

@stale
Copy link

stale bot commented May 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 12, 2021
@stale stale bot closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to Android platform feature request New feature request Firebase SDK Relates to the Firebase SDK library which this plugin wraps ios relates to iOS platform wontfix
Projects
None yet
Development

No branches or pull requests

5 participants