Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top menu links order problem (and difference between "mobile" and "non-mobile") #58

Open
chrisave opened this issue Jun 30, 2017 · 1 comment
Assignees

Comments

@chrisave
Copy link

Hello,
I hope you are doing well!
I've just found vital today.
I'm only going to mention what I've noticed concerning the menu.
I like the fact that the ("mobile") menu works without javascript.

For https://vitalcss.com/, http://vitalcss.s3-website-us-east-1.amazonaws.com/ and https://engineering.doximity.com/ the top menu links are reverted (relative to the order in the source code).
The "mobile" menu is in the same order.
But I guess that the wanted (display) order is the same as the "non-mobile" menu one.
For https://vitalcss.com/ and http://vitalcss.s3-website-us-east-1.amazonaws.com/ at least, in Chrome/Chromium Developer Tools, be it for the "non-mobile" menu and/or the "mobile" one, I see several float overrides (vital css and demo css).

To have the same order, why not remove the lines:

  • float: right; from .header nav ul li (demo css)
  • float: right; from .menu li (vital css)
  • float: none; from @media screen and (max-width: 860px) .menu * (vital css)
    and add float: right; to .menu with a media query starting at 861px

Then the menu links can be put in the right order in the source code/back-end.

Doesn't it solve the issue (and without the first h1 tag having display problems)?

Have a nice weekend!

@bodytaing
Copy link
Contributor

Hi @chrisave thanks for the suggestion. I will work on adding something of that nature!

@bodytaing bodytaing self-assigned this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants