-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
callSite.getFileName
is not a function
#50
Comments
Hi @loynoir thanks for reporting! As far as I am aware, all versions of Node.js have that function, and also the error looks weird and there is no stack trace. Can you help by providing the following information?
Thank you! |
|
Oh, I see now, it's something to do with |
Ah I delete that warning, I guess easier to read.
|
Ah. But yea, as the Node.js docs state:
I'll take a look into what it would take to support that and see how the flag varies across the Node.js versions released so far to get a hint at future direction of the experimental feature too. For now, I would suggest not using that feature if you want to use this module. |
I'm not sure what that link means. |
There is nodejs contributor suggestion, maybe, to use that flag to protect prototype pollution instead of crashed |
Ah. But yea, like I pointed out, the Node.js documentation for
And it looks like indeed, this code does break under that flag. Node.js seems well aware you're going to run into issues with that experimental feature. Like I said, I will look into what it would take to work with that flag, if it is even possible. But it is experimental and as Node.js states:
I will try my best to support it, but supporting experimental features are hard by their nature of random changes without concern for breaking things. |
Ah, have a look where is the first place goes wrong when using that flag. Line 386 in 7ad9a48
So, this seems related to #16 with
|
The text was updated successfully, but these errors were encountered: