When a new master is initialized, make it writable when ignoreReadOnl…

…y is true.

pkg/controller/node/node_controller.go

@@ -267,7 +267,11 @@ func (r *ReconcileMysqlNode) initializeMySQL(ctx context.Context, sql SQLInterfa
 	if err != nil {
 		return err
 	}
-	defer enableSuperReadOnly()
+	defer func() {
+		if !cluster.Spec.IgnoreReadOnly {
+			enableSuperReadOnly()
+		}
+	}()
 
 	// check if the skip GTID_PURGED annotation is set on the cluster first
 	// and if it's set then mark the GTID_PURGED set in status table
@@ -289,6 +293,12 @@ func (r *ReconcileMysqlNode) initializeMySQL(ctx context.Context, sql SQLInterfa
 		if err := sql.ChangeMasterTo(ctx, cluster.GetMasterHost(), c.ReplicationUser, c.ReplicationPassword); err != nil {
 			return err
 		}
+	} else if cluster.Spec.IgnoreReadOnly {
+		// When ignoreReadOnly setting is true, then only on initialization, we will set the master to writable.
+		// This kicks off the new cluster with a writable master; otherwise it would never be marked writable, as the
+		//ignoreReadOnly setting prevents any interference whatsoever in the Orchestrator reconciliation loop.
+		log.Info("setting master writable on initialization *only* due to ignoreReadOnly=true")
+		sql.DisableReadOnly(ctx)
 	}
 
 	// write the configuration complete flag into MySQL, this will make the node ready

pkg/controller/node/sql.go

@@ -38,6 +38,7 @@ const (
 type SQLInterface interface {
 	Wait(ctx context.Context) error
 	DisableSuperReadOnly(ctx context.Context) (func(), error)
+	DisableReadOnly(ctx context.Context) error
 	ChangeMasterTo(ctx context.Context, host string, user string, pass string) error
 	MarkConfigurationDone(ctx context.Context) error
 	IsConfigured(ctx context.Context) (bool, error)
@@ -90,6 +91,10 @@ func (r *nodeSQLRunner) DisableSuperReadOnly(ctx context.Context) (func(), error
 	return enable, r.runQuery(ctx, "SET GLOBAL READ_ONLY = 1; SET GLOBAL SUPER_READ_ONLY = 0;")
 }
 
+func (r *nodeSQLRunner) DisableReadOnly(ctx context.Context) error {
+	return r.runQuery(ctx, "SET GLOBAL SUPER_READ_ONLY = 0; SET GLOBAL READ_ONLY = 0;")
+}
+
 // ChangeMasterTo changes the master host and starts slave.
 func (r *nodeSQLRunner) ChangeMasterTo(ctx context.Context, masterHost, user, pass string) error {
 	// slave node

pkg/controller/node/sql_fake_test.go

@@ -36,6 +36,10 @@ func (f *fakeSQLRunner) DisableSuperReadOnly(ctx context.Context) (func(), error
 	return func() {}, nil
 }
 
+func (f *fakeSQLRunner) DisableReadOnly(ctx context.Context) error {
+	return nil
+}
+
 func (f *fakeSQLRunner) ChangeMasterTo(ctx context.Context, host, user, pass string) error {
 	return nil
 }