Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website has blocking resources #408

Open
doug-wade opened this issue Aug 12, 2023 · 4 comments
Open

Website has blocking resources #408

doug-wade opened this issue Aug 12, 2023 · 4 comments
Labels
bug Something isn't working website

Comments

@doug-wade
Copy link
Owner

doug-wade commented Aug 12, 2023 •
edited
Loading

Chrome lighthouse is reporting

Resources are blocking the first paint of your page. Consider delivering critical JS/CSS inline and deferring all non-critical JS/styles. Learn how to eliminate render-blocking resources.FCPLCP

This is a screenshot of the issue quoted above
@doug-wade doug-wade added bug Something isn't working good first issue Good for newcomers website and removed good first issue Good for newcomers labels Aug 12, 2023
@doug-wade
Copy link
Owner Author

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preload

@Ashvith10
Copy link
Contributor

Should switching from CDN to local fonts resolve the first issue?

@doug-wade
Copy link
Owner Author

doug-wade commented Aug 15, 2023 •
edited
Loading

I don't think so, but I don't actually know. I think what they want us to do is to add a rel="preload" attribute to each of our css links, but I'm not 100% sure. If I were working this ticket, I would grab start by adding a rel="preload" to my locally-running instance and start lighthouse locally in an incognito window to see if it resolves the issue, and then read the article they linked while it runs.

@doug-wade
Copy link
Owner Author

doug-wade commented Aug 15, 2023 •
edited
Loading

So it might be as easy as changing

<link
    href="https://fonts.googleapis.com/css2?family=DM+Mono&family=DM+Sans:ital,wght@0,400;0,700;1,400&display=swap"
    rel="stylesheet"
/>
<link href="https://unpkg.com/[email protected]/themes/prism-night-owl.css" rel="stylesheet" />

to

<link
    href="https://fonts.googleapis.com/css2?family=DM+Mono&family=DM+Sans:ital,wght@0,400;0,700;1,400&display=swap"
    rel="preload"
/>
<link href="https://unpkg.com/[email protected]/themes/prism-night-owl.css" rel="preload" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doug-wade @Ashvith10