Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website is missing lang attribute #407

Closed
doug-wade opened this issue Aug 12, 2023 · 2 comments
Closed

Website is missing lang attribute #407

doug-wade opened this issue Aug 12, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers website

Comments

@doug-wade
Copy link
Owner

doug-wade commented Aug 12, 2023 •
edited
Loading

Chrome lighthouse is reporting

If a page doesn't specify a lang attribute, a screen reader assumes that the page is in the default language that the user chose when setting up the screen reader. If the page isn't actually in the default language, then the screen reader might not announce the page's text correctly. Learn more about the lang attribute.

This is a screenshot of the issue quoted above
@doug-wade doug-wade added bug Something isn't working good first issue Good for newcomers website labels Aug 12, 2023
@doug-wade
Copy link
Owner Author

We'll need to add the new attribute right here: https://github.com/doug-wade/tybalt/blob/master/packages/website/index.html#L2

@conorvenus conorvenus mentioned this issue Aug 12, 2023
Merged
@doug-wade
Copy link
Owner Author

Verified this is resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doug-wade