Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIA Openness Integration: Limited to S7-1500 devices #149

Closed
thomasb454 opened this issue Mar 11, 2020 · 3 comments
Closed

TIA Openness Integration: Limited to S7-1500 devices #149

thomasb454 opened this issue Mar 11, 2020 · 3 comments

Comments

@thomasb454
Copy link
Contributor

Hi

I'm just curious as to the reason the TIA Openness Integration is limited to S7-1500 devices?
(https://github.com/dotnetprojects/DotNetSiemensPLCToolBoxLibrary/blob/master/DotNetSiemensPLCToolBoxLibrary.TIAV15_1/Step7ProjectV15_1Tia.cs#L861)

In a local copy, I have omitted this check and to my knowledge, everything is working correctly. Have I missed something?

Thank you
Tom
@jogibear9988
Copy link
Member

Maybe you could create a pull req? Don't know anymore why I did thsi.

@thomasb454
Copy link
Contributor Author

I certainly will when I get some time :)

@thomasb454 thomasb454 mentioned this issue May 7, 2020
Merged
@thomasb454
Copy link
Contributor Author

#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jogibear9988 @thomasb454