Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK version and disable module initializer warning #5088

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

ryalanms
Copy link
Member

WPF relies on a module initializer to load DirectWriteForwarder before PresentationCore is used. WPF previously used ILasm/ILdasm to create the module initializer but now uses the language feature. In new versions of the SDK, the analyzer gives a warning that must be suppressed: dotnet/runtime#43328.

@ryalanms ryalanms requested a review from a team as a code owner August 17, 2021 20:05
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 17, 2021
@ghost ghost requested review from fabiant3 and SamBent August 17, 2021 20:06
@ryalanms ryalanms merged commit 8d469a6 into main Aug 17, 2021
@vishalmsft vishalmsft deleted the update.sdk branch February 10, 2022 06:04
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants