Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blinkInterval causes crash if it overflows when multiplying by 2 #10089

Open
kayle opened this issue Nov 18, 2024 · 3 comments
Open

blinkInterval causes crash if it overflows when multiplying by 2 #10089

kayle opened this issue Nov 18, 2024 · 3 comments
Labels
Investigate Requires further investigation by the WPF team.

Comments

@kayle
Copy link

kayle commented Nov 18, 2024

This code should be updated to verify the blinkInterval is valid before creating a Duration object:

Image

This is the root cause of https://developercommunity.visualstudio.com/t/Trying-to-search-in-a-file-crashes-VS/10736121#T-ND10793055

@miloush
Copy link
Contributor

miloush commented Nov 18, 2024

What would be the desired behavior in the case of overflow? Max value or no blinking?

Edit: Moving the * 2 to the declaration would probably fix it for "no blinking".

@kayle
Copy link
Author

kayle commented Nov 18, 2024

I personally don't have a preference between not blinking vs blinking once every few weeks :)

@miloush
Copy link
Contributor

miloush commented Nov 18, 2024

good point

@harshit7962 harshit7962 added the Investigate Requires further investigation by the WPF team. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigate Requires further investigation by the WPF team.
Projects
None yet
Development

No branches or pull requests

3 participants