-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing project system triggers incorrect restore prompt and reprocesses projects multiple times #141
Comments
The version of the C# extension that you have isn't really meant to work with .NET CLI. You can build the dev branch if you want something that should work. |
@gregg-miskelly I believe @natemcmaster is indeed use the OmniSharp-Roslyn build from dev branch. The problem here is the effect of combination of omnisharp-roslyn's relentless restore effort and VS Code's notification mode. Here's what happened. When O# loads the projects it looks at each projects' dependencies. If there are any unresolved dependencies, it triggers a In the case when there are a lot of unresolved projects, for example negative test case samples, there will be a lot of warning messages. What does surprise me is that it repeatedly processes one project over and over. This should be OmniSharp-Roslyn issue. This is indeed something we can improve. |
Reclassifying this issue. It isn't really a bug since it's working as it was implemented ages ago. However, the experience is terrible. 😄 |
VS Code version: 1.22.2 I have a solution with 10 projects. If I execute the @natemcmaster Can you check if the issue reproduces for the updated version of the extension as well ? |
No repro anymore. A few things have changed in the project system since the days of project.json. I'm sure somewhere in the last 2 years someone already fixed this. Thanks for the follow up though. |
Repro step
Clone entity framework to Mac.
From command line:
dotnet restore
(should succeed)Open VS Code.
Select the whole "solution" in "Omnisharp: Select Project".
Expected behavior
Initialize project state and intellisense. No restore necessary.
Actual behavior
VS Code produces dozens of errors "There are unresolved dependencies from '(project)'. Please execute the restore command to continue." This is produce multiple times per project.
Furthermore, the Omnisharp output shows it is continually processing the same projects over and over. Appears to have processed each project state about 40 times.
Full log:
omnisharp-log.txt
After about ~4 minutes, project initialization appears done and omnisharp operates as expected.
My setup
VS Code 0.10.11
Using C# 0.3.7
Using omnisharp-roslyn build locally from OmniSharp/omnisharp-roslyn@aab690c (result of mergeing OmniSharp/omnisharp-roslyn#501)
The text was updated successfully, but these errors were encountered: