Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redirect and RedirectPermanent to HttpResponseBase and HttpResponseWrapper. #472

Closed
AvremelM opened this issue Jan 24, 2024 · 2 comments
Labels
Needs: Triage 🔍 Label added to new issues which need Triage

Comments

@AvremelM
Copy link
Contributor

Summary

Adds Redirect and RedirectPermanent methods to HttpResponseBase and HttpResponseWrapper classes.

Motivation and goals

These APIs are part of System.Web.HttpResponseBase and System.Web.HttpResponseWrapper in .NET 4.0

Looks like this possibly(?) could have been added after #102 or #233, when these methods were added to HttpResponse.

Examples

HttpResponseBase response = new HttpContextWrapper(HttpContext.Current).Response;

response.Redirect(newUrl);
response.Redirect(newUrl, true);

response.RedirectPermanent(newUrl);
response.RedirectPermanent(newUrl, true);
@dotnet-policy-service dotnet-policy-service bot added the Needs: Triage 🔍 Label added to new issues which need Triage label Jan 24, 2024
@AvremelM
Copy link
Contributor Author

AvremelM commented Jan 24, 2024

I've begun adding support for this here.

I'm having a bit of trouble getting my local environment set up for this repo.

Edit: Took me a while to figure out how I was supposed to open this solution and build/package it.
It might be worthwhile to have the basics documented somewhere, e.g., README.md or CONTRIBUTING.md
I would write it myself, but I honestly don't understand it well enough.

@AvremelM AvremelM changed the title Add Redirect and RedirectPermanent methods to HttpResponseBase and HttpResponseWrapper. Add Redirect and RedirectPermanent to HttpResponseBase and HttpResponseWrapper. Jan 24, 2024
@AvremelM
Copy link
Contributor Author

AvremelM commented Feb 4, 2024

Any way to expedite this merge? I have two relatively straightforward PRs (#473 and #477) that are ready to merge, (afaict). Just need someone to look over them.

Sorry to be a bother, just have a few projects that are waiting on these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Label added to new issues which need Triage
Projects
None yet
Development

No branches or pull requests

1 participant