Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceLink fails in git worktree and emits many build warnings #473

Closed
AArnott opened this issue Oct 31, 2019 · 1 comment · Fixed by #463
Closed

SourceLink fails in git worktree and emits many build warnings #473

AArnott opened this issue Oct 31, 2019 · 1 comment · Fixed by #463

Comments

@AArnott
Copy link

AArnott commented Oct 31, 2019

When building in a worktree, all projects emit this warning:

...\microsoft.build.tasks.git\1.0.0-beta2-19367-01\build\Microsoft.Build.Tasks.Git.targets(24,5): warning : Unable to locate repository with working directory that contains directory 'D:\git\MessagePack-CSharp.v1.8\src\MessagePack.ReactiveProperty'.

Using Microsoft.SourceLink.GitHub v1.0.0-beta2-19367-01.
Similar to #347

@tmat
Copy link
Member

tmat commented Oct 31, 2019

The problem is with commondir file containing a relative path that we don't normalize.

@tmat tmat closed this as completed in #463 Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants