Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CA2022 suppressions #4322

Open
NikolaMilosavljevic opened this issue Apr 12, 2024 · 3 comments
Open

Remove unnecessary CA2022 suppressions #4322

NikolaMilosavljevic opened this issue Apr 12, 2024 · 3 comments

Comments

@NikolaMilosavljevic
Copy link
Member

As part of re-bootstrapping in dotnet/installer#19145 we've encountered numerous CA2022 errors. This required patches for several repos. Most of those changes were backported.

It appears that compiler/analyzer was unnecessarily restrictive and the change was made in dotnet/roslyn-analyzers#7268 to relax the check.

Once we pick up newer SDK (9.0.100-preview.4.24209.7 or later) we should be able to remove all of these suppressions and backport them.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons
Copy link
Member

[Triage] Is there anymore work to do here? The last patches are being removed in dotnet/installer#19508.

@NikolaMilosavljevic
Copy link
Member Author

This issue tracks removal of suppressions that were added with dotnet/installer#19145

Analyzer was too restrictive - it was fixed with dotnet/roslyn-analyzers#7268

This work can be done after next VMR re-bootstrapping.

@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Apr 19, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 10.0
Development

No branches or pull requests

2 participants