Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making src modifications to every repo's global.json #3169

Open
Tracked by #3664
MichaelSimons opened this issue Dec 9, 2022 · 2 comments
Open
Tracked by #3664

Stop making src modifications to every repo's global.json #3169

MichaelSimons opened this issue Dec 9, 2022 · 2 comments
Labels
area-infra Source-build infrastructure and reporting

Comments

@MichaelSimons
Copy link
Member

When building the VMR, there are several checked in files that are being modified. This yields a poor UX as these must be undone before you can build cleanly again. These edits will also become a nuisance in .NET 9 when the VMR can be used to checkin changes.

One type of file being modified is each repo's global.json. The repo's global.json is updated to use the dotnet version specified in the VMR's global.json

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons moved this to 8.0 Preview 1 in .NET Source Build Dec 9, 2022
@MichaelSimons MichaelSimons added area-infra Source-build infrastructure and reporting and removed untriaged labels Dec 15, 2022
@MichaelSimons MichaelSimons moved this from 8.0 Preview 1 to 8.0 Backlog in .NET Source Build Feb 9, 2023
@MichaelSimons MichaelSimons moved this from Needs Review to 8.0 Backlog in .NET Source Build Jun 8, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 9.0 Lull in .NET Source Build Jul 20, 2023
@MichaelSimons MichaelSimons moved this from Post 8.0 / Pre 9.0 to Preview 1 in .NET Source Build Nov 14, 2023
@mmitche
Copy link
Member

mmitche commented Jan 3, 2024

Also related: #3781. See costings there.

@MichaelSimons MichaelSimons moved this from 9.0 Preview 1 to 9.0 Preview 2 in .NET Source Build Jan 17, 2024
@MichaelSimons MichaelSimons moved this from 9.0 Preview 2 to 9.0 in .NET Source Build Feb 20, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
Status: 10.0
Status: No status
Development

No branches or pull requests

2 participants