Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build runtime repo using --allconfigurations #1838

Closed
dseefeld opened this issue Oct 27, 2020 · 2 comments
Closed

Build runtime repo using --allconfigurations #1838

dseefeld opened this issue Oct 27, 2020 · 2 comments
Labels
area-build Improvements in source-build's own build process

Comments

@dseefeld
Copy link
Contributor

Currently, packages built in the libraries subset of the runtime repo build are only built for the current TFM (net5.0). This causes issues when using these packages when the consumer is building with other TFMs. This causes workarounds that make the source-built product different than the official builds of the product. Building the libraries with the --allconfigurations flag would allow them to be built from source for all supported TFMs. An initial build with --allconfigurations was attempted, but ran into issues with TypeForwards not generating correctly for some packages. Discussions with the runtime team have indicated that it may be related to GenFacades not supporting ILRewriting in source-build. This needs more investigation.

@ericstj
Copy link
Member

ericstj commented May 19, 2021

@dseefeld I believe this should be unblocked now that dotnet/runtime#52793 is merged. Can you give this a try and see if it works now?

@MichaelSimons
Copy link
Member

This has been implemented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Improvements in source-build's own build process
Projects
None yet
Development

No branches or pull requests

3 participants