Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #27406

Merged
merged 16 commits into from
Sep 6, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 24, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20220904.3
  • Date Produced: September 4, 2022 11:56:12 PM UTC
  • Commit: 75e65e99af5b3c8a2fd0abd5e887f8b14bd45362
  • Branch: refs/heads/main

…0823.18

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22423.18
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

2 similar comments
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…0824.15

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22424.15
@wtgodbe wtgodbe enabled auto-merge (squash) August 25, 2022 17:02
…0825.20

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22425.20
@kasperk81
Copy link
Contributor

@jkoritzinsky, @pavelsavara, .net framework failure in interop analyzer:

      "C:\h\w\A569092E\t\dotnetSdkTests\atwygha2.utb\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj" (Build target) (1:7) ->
      (CoreCompile target) -> 
        CSC : error CS9057: The analyzer assembly 'C:\h\w\A569092E\t\dotnetSdkTests\atwygha2.utb\.nuget\packages\microsoft.netcore.app.ref\8.0.0-alpha.1.22425.20\analyzers\dotnet\cs\Microsoft.Interop.JavaScript.JSImportGenerator.dll' references version '4.4.0.0' of the compiler, which is newer than the currently running version '4.3.0.0'. [C:\h\w\A569092E\t\dotnetSdkTests\atwygha2.utb\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj]
        CSC : error CS9057: The analyzer assembly 'C:\h\w\A569092E\t\dotnetSdkTests\atwygha2.utb\.nuget\packages\microsoft.netcore.app.ref\8.0.0-alpha.1.22425.20\analyzers\dotnet\cs\Microsoft.Interop.LibraryImportGenerator.dll' references version '4.4.0.0' of the compiler, which is newer than the currently running version '4.3.0.0'. [C:\h\w\A569092E\t\dotnetSdkTests\atwygha2.utb\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj]
      
          1 Warning(s)
          2 Error(s)

@jkoritzinsky
Copy link
Member

We moved to target the version of the compiler in the .NET 7 P7 SDK as Arcade has updated to the P7 SDK as a baseline. Once #27228 is merged (or we manually update to the P7 SDK), this PR will be unblocked.

…0826.13

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22426.13
…0827.5

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22427.5
@danmoseley
Copy link
Member

The arcade update happened. Reopening to rerun

@danmoseley danmoseley closed this Aug 30, 2022
auto-merge was automatically disabled August 30, 2022 04:07

Pull request was closed

@danmoseley danmoseley reopened this Aug 30, 2022
…0829.10

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22429.10
@danmoseley
Copy link
Member

Some cases of "##[error]File upload failed even after retry." but some actionable:

        "C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj" (Build target) (1:7) ->
        (_ReportUpgradeNetAnalyzersNuGetWarning target) -> 
          C:\h\w\A7D508E4\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\analyzers\build\Microsoft.CodeAnalysis.NetAnalyzers.targets(592,5): warning : The .NET SDK has newer analyzers with version '7.0.0' than what version '5.0.3' of 'Microsoft.CodeAnalysis.NetAnalyzers' package provides. Update or remove this package reference. [C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj]
        
        
        "C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj" (Build target) (1:7) ->
        (CoreCompile target) -> 
          CSC : error CS9057: The analyzer assembly 'C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\.nuget\packages\microsoft.netcore.app.ref\8.0.0-alpha.1.22429.10\analyzers\dotnet\cs\Microsoft.Interop.JavaScript.JSImportGenerator.dll' references version '4.4.0.0' of the compiler, which is newer than the currently running version '4.3.0.0'. [C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj]
Running C:\h\w\A7D508E4\p\d\dotnet.exe C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\ItRunsAppsDir---2C2B5D7A\Referencer\bin\Debug\net7.0\Referencer.dll
          CSC : error CS9057: The analyzer assembly 'C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\.nuget\packages\microsoft.netcore.app.ref\8.0.0-alpha.1.22429.10\analyzers\dotnet\cs\Microsoft.Interop.LibraryImportGenerator.dll' references version '4.4.0.0' of the compiler, which is newer than the currently running version '4.3.0.0'. [C:\h\w\A7D508E4\t\dotnetSdkTests\1340zlkp.pmn\AnalyzersAreC---4DE360D4\AnalyzersAreConflictResolved\AnalyzersAreConflictResolved.csproj]
Process ID: 2668

@danmoseley
Copy link
Member

@jkoritzinsky any idea why we're still getting the version errors?

@jkoritzinsky
Copy link
Member

I'll take a look and try to figure it out.

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Aug 30, 2022

It passes locally for me. Given that the failure is only on desktop MSBuild, I'm inclined to believe that the VS version on the machines the tests run on is 16.3 of some variant, not a 16.4 preview.

@dotnet/dnceng can someone check the VS version in the Windows.Amd64.VS2022.Pre.Open helix image and let us know what VS version is on it?

Edit: I typed 16.x but meant 17.x, my mistake (only noticing now)

@MattGal
Copy link
Member

MattGal commented Aug 30, 2022

It passes locally for me. Given that the failure is only on desktop MSBuild, I'm inclined to believe that the VS version on the machines the tests run on is 16.3 of some variant, not a 16.4 preview.

@dotnet/dnceng can someone check the VS version in the Windows.Amd64.VS2022.Pre.Open helix image and let us know what VS version is on it?

This information is self-service:

https://helix.dot.net/#1ESHostedPoolImagesWestUS-rg-Public-Windows shows it as 17.3.0-pre6:
image

@kasperk81
Copy link
Contributor

it shows MSBuild version 17.3.0+f67e3d35e for .NET Framework in the log https://helix.dot.net/api/2019-06-17/jobs/7a0cd2d7-cc93-45ee-9b07-fbe0c7f53376/workitems/Microsoft.NET.Build.Tests.dll.10/console

@jkoritzinsky
Copy link
Member

Okay that'll do it. Any chance we can get that upgraded to VS 17.4 Preview 1?

@MattGal
Copy link
Member

MattGal commented Aug 30, 2022

Okay that'll do it. Any chance we can get that upgraded to VS 17.4 Preview 1?

Yes, this is currently available already in the VS 2022 Preview "Scouting" build images but not in Helix test images because we generally try to discourage tests depending on bleeding-edge versions of VS being installed. It will naturally flow to your queue when "normal" preview VS 2022 becomes this version on the build machines. I'd estimate (no promises here) that will happen on 9/7/2022

See https://github.com/dotnet/core-eng/blob/main/Documentation/Policy/VS2019SupportPolicy.md (just imagine the 2019s are 2022s) for a rough idea how this works.

…0830.9

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22430.9
@jkoritzinsky
Copy link
Member

@kasperk81 what's your recommendation here? We can't roll back the Roslyn version we're referencing (and there's similar work coming down the pipeline for release/7.0 in dotnet/runtime#74822). I can think of two options:

  1. Disable the failing tests on the FullFramework builds temporarily until the helix machines are updated.
  2. Reference the Microsoft.NET.Compilers.Toolset package from the various different test asset projects that are failing to ensure that they're referencing a new enough Roslyn version (as the Roslyn version that ends up being used in the FullFramework builds isn't the same version that will eventually ship with a VS version that supports the SDK at the current commit).

Which of these options would you prefer, or do you have another option that you like better?

@kasperk81
Copy link
Contributor

first option (with an issue to enable the tests after 9/7) sounds good to unblock this pr.
related: installer is blocked on full net8.0 migration for a few weeks: dotnet/installer#14340, so the flux is frozen in grand scheme of things.

…0831.12

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22431.12
@jkoritzinsky
Copy link
Member

I started working on this and noticed that the only tests that fail are ones that set TreatWarningsAsErrors to true without setting CodeAnalysisTreatWarningsAsErrors to false. Instead of locking these tests to Core MSBuild, I'm going to add code into the tests to disable the particular error that's happening and leave it as a warning so that we don't need to remember how we fixed this if the generators move faster than the desktop MSBuild install again.

@am11 am11 mentioned this pull request Sep 2, 2022
29 tasks
…0901.20

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22451.20
@jkoritzinsky
Copy link
Member

New non-wasm failures should be fixed by dotnet/runtime#74943.

For the wasm failures: @pavelsavara @maraf

dotnet-maestro bot and others added 5 commits September 3, 2022 12:09
…0902.15

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22452.15
…0903.2

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22453.2
…0904.3

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-alpha.1.22422.24 -> To Version 8.0.0-alpha.1.22454.3
@pavelsavara
Copy link
Member

File upload failed even after retry. is the last error. Who can help ?

@kasperk81
Copy link
Contributor

File upload failed even after retry. is the last error. Who can help ?

known issue: #19679 and dotnet/arcade#9026.

@danmoseley
Copy link
Member

Running the failed legs again

@dotnet-maestro dotnet-maestro bot merged commit 459df26 into main Sep 6, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-3098471e-4e77-460b-ab14-39b058e5c306 branch September 6, 2022 01:36
@danmoseley
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants