Fix building projects restored with NuGet 5.7 #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
nuget-restore-compat
branch
from
e3b75e1 to
75c0ffa
Compare
nkolev92
reviewed
Nov 12, 2020
| { | ||
| LockFileTarget lockFileTarget = lockFile.GetTarget(frameworkAlias, runtime); | ||
| LockFileTarget lockFileTarget = lockFile.GetTarget(frameworkAlias, runtimeIdentifier); |
| } | ||
|
|
||
| [WindowsOnlyFact] | ||
| public void ItCanBuildProjectRestoredWithNuGet5_7() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix builds when assets file was created by an earlier version of NuGet.
Bugs:
Customer Impact
This will fix issues where CI builds fail because they download an older version of NuGet.exe and use this for restore.
How found
Azure pipelines canary testing
Test coverage
Automated test coverage is added with this PR
Regression?
Yes.
We had previously decided that we did not need to support building with assets files created by an earlier version of NuGet. We did not realize the impact this would have on CI builds, where it is a common pattern to download NuGet.exe and use it for the restore, and the version of NuGet.exe used may not match the version of NuGet used by the build.
Because of this impact, we have reconsidered this breaking change.
Risk
Low risk that this would break new scenarios.
Medium-low risk that there are some scenarios we haven't found that would still be broken when restoring with a previous NuGet version.