Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive NU5017 #42660

Closed
taori opened this issue Aug 11, 2024 · 4 comments
Closed

False positive NU5017 #42660

taori opened this issue Aug 11, 2024 · 4 comments
Labels
Area-NuGet untriaged Request triage from a team member

Comments

@taori
Copy link

taori commented Aug 11, 2024

Describe the bug

See: https://github.com/taori/Amusoft.DotnetNew.Tests/actions/runs/10324643081/job/28619361962

image
For some reason i am getting this error, despite a nupkg being created. when i open the nupkg the contents appear to be just fine and contain the classes that were compiled with it

To Reproduce

I would suggest forking https://github.com/taori/Amusoft.DotnetNew.Tests. I am having the same issue locally. I will try to mark this error as error to try workaround the issue, but clearly this isn't ideal. #29053 mentions this issue happening for .net7, but i also have it on .net6

Exceptions (if any)

Further technical details

  • Include the output of dotnet --info
  • The IDE (VS / VS Code/ VS4Mac) you're running on, and its version
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Aug 11, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@taori
Copy link
Author

taori commented Aug 11, 2024

It appears to be related to this: NuGet/Home#10372

Once i comment out like this:

image

dotnet pack works fine

@taori
Copy link
Author

taori commented Aug 11, 2024

After some digging i was able to find out why this happens. I duplicated properties in the project.csproj which overwrote the SourceLink.props, where it is correct. Not a bug - My mistake

@taori taori closed this as completed Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NuGet untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants