Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.NET.Sdk TargetFramework parsing to understand OS name and versions #11231

Closed
dsplaisted opened this issue Apr 10, 2020 · 1 comment · Fixed by #12632
Closed

Update Microsoft.NET.Sdk TargetFramework parsing to understand OS name and versions #11231

dsplaisted opened this issue Apr 10, 2020 · 1 comment · Fixed by #12632
Assignees
@sfoslund
Milestone
5.0.1xx

Comments

@dsplaisted
Copy link
Member

The parsing in Microsoft.NET.TargetFrameworkInference.targets needs to be updated to parse the TargetPlatformIdentifier and TargetPlatformVersion from the TargetFramework.

The existing parsing implementation (which uses string manipulation) should be replaced with calls to new MSBuild Intrinsic functions which will call the NuGet parsing APIs.

.NET 5 TargetFramework spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfoslund sfoslund

Labels
None yet
Projects
None yet
Milestone
5.0.1xx
3 participants
@dsplaisted @wli3 @sfoslund