Report diagnostics for bad opt-in marshallers at MarshalUsing use-site if the marshaler is in a different compilation than the current compilation. #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if the marshaler is in a different compilation than the current compilation.
jkoritzinsky
added
the
area-DllImportGenerator
elinor-fung
approved these changes
Jul 7, 2021
DllImportGenerator/DllImportGenerator/Analyzers/ManualTypeMarshallingAnalyzer.cs
Show resolved
Hide resolved
jkoritzinsky
commented
Jul 7, 2021
DllImportGenerator/DllImportGenerator/Analyzers/ManualTypeMarshallingAnalyzer.cs
Show resolved
Hide resolved
…hallingAnalyzer.cs
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
…e if the marshaler is in a different compilation than the current compilation. (dotnet/runtimelab#1300) Commit migrated from dotnet/runtimelab@d4b5fd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that we still provide diagnostics for custom native type marshallers even if the marshaller lives in a different assembly.