From 2283844f48f9ff1fa2940f61d12f94c92b80bcad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sun, 27 Sep 2020 09:51:04 +0200 Subject: [PATCH 1/8] Add Pri-0 test pipeline --- eng/pipelines/runtimelab/coreclr-tests.yml | 44 +++++++++++++++++++ .../runtimelab-post-build-steps.yml | 3 +- 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 eng/pipelines/runtimelab/coreclr-tests.yml diff --git a/eng/pipelines/runtimelab/coreclr-tests.yml b/eng/pipelines/runtimelab/coreclr-tests.yml new file mode 100644 index 000000000000..885f68b54214 --- /dev/null +++ b/eng/pipelines/runtimelab/coreclr-tests.yml @@ -0,0 +1,44 @@ +trigger: none + +pr: none + +jobs: +# +# Checkout repository +# +- template: /eng/pipelines/common/checkout-job.yml + +# +# Build with Debug config and Checked runtimeConfiguration +# +- template: /eng/pipelines/common/platform-matrix.yml + parameters: + jobTemplate: /eng/pipelines/common/global-build-job.yml + buildConfig: Checked + platforms: + - Windows_NT_x64 + jobParameters: + timeoutInMinutes: 720 + testGroup: innerloop + buildArgs: -s nativeaot+libs+installer -lc release -rc checked + extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml + extraStepsParameters: + smokeTestsOnly: 'false' + + +# +# Build with Release config and Release runtimeConfiguration +# +- template: /eng/pipelines/common/platform-matrix.yml + parameters: + jobTemplate: /eng/pipelines/common/global-build-job.yml + buildConfig: Release + platforms: + - Windows_NT_x64 + jobParameters: + timeoutInMinutes: 720 + testGroup: innerloop + buildArgs: -s nativeaot+libs+installer -c $(_BuildConfig) /p:ArchiveTests=true + extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml + extraStepsParameters: + smokeTestsOnly: 'false' diff --git a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml index e3ce11840244..204a5630b66d 100644 --- a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml +++ b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml @@ -4,11 +4,12 @@ parameters: osGroup: '' osSubgroup: '' uploadTests: false + smokeTestsOnly: 'true' steps: # Build coreclr native test output - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: - - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) nativeaot skipstressdependencies $(buildConfigUpper) ${{ parameters.archType }} /p:NativeAotMultimodule=true /p:SmokeTestsOnly=true + - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) nativeaot skipstressdependencies $(buildConfigUpper) ${{ parameters.archType }} /p:NativeAotMultimodule=true /p:SmokeTestsOnly=${{ parameters.smokeTestsOnly }} displayName: Build tests - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) nativeaot skipstressdependencies $(buildConfigUpper) ${{ parameters.archType }} /p:SmokeTestsOnly=true From 450ffbd7d9a9e0fec208f4bb671f1100394ba23f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sun, 27 Sep 2020 10:51:55 +0200 Subject: [PATCH 2/8] Oops --- eng/pipelines/runtimelab.yml | 2 -- eng/pipelines/runtimelab/coreclr-tests.yml | 2 ++ .../runtimelab/runtimelab-post-build-steps.yml | 14 +++++++++----- src/tests/Common/CLRTest.Execute.Batch.targets | 5 +++++ 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/eng/pipelines/runtimelab.yml b/eng/pipelines/runtimelab.yml index 078c4290e5e3..cbe8d4c332bd 100644 --- a/eng/pipelines/runtimelab.yml +++ b/eng/pipelines/runtimelab.yml @@ -85,5 +85,3 @@ jobs: testGroup: innerloop buildArgs: -s nativeaot+libs+installer -c $(_BuildConfig) /p:ArchiveTests=true extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml - extraStepsParameters: - uploadTests: true diff --git a/eng/pipelines/runtimelab/coreclr-tests.yml b/eng/pipelines/runtimelab/coreclr-tests.yml index 885f68b54214..bf188c8bdfeb 100644 --- a/eng/pipelines/runtimelab/coreclr-tests.yml +++ b/eng/pipelines/runtimelab/coreclr-tests.yml @@ -24,6 +24,7 @@ jobs: extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml extraStepsParameters: smokeTestsOnly: 'false' + runSingleFileTests: false # @@ -42,3 +43,4 @@ jobs: extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml extraStepsParameters: smokeTestsOnly: 'false' + runSingleFileTests: false diff --git a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml index 204a5630b66d..cf7bd373be92 100644 --- a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml +++ b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml @@ -5,6 +5,7 @@ parameters: osSubgroup: '' uploadTests: false smokeTestsOnly: 'true' + runSingleFileTests: true steps: # Build coreclr native test output @@ -15,11 +16,14 @@ steps: - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) nativeaot skipstressdependencies $(buildConfigUpper) ${{ parameters.archType }} /p:SmokeTestsOnly=true displayName: Build tests - - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: - - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) runnativeaottests $(buildConfigUpper) ${{ parameters.archType }} + - ${{ if eq(parameters.runSingleFileTests, true) }}: + - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: + - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) runnativeaottests $(buildConfigUpper) ${{ parameters.archType }} + displayName: Run tests in single file mode + - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: + - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) --runnativeaottests $(buildConfigUpper) ${{ parameters.archType }} displayName: Run tests in single file mode + + - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) runnativeaottests nativeaotmultimodule $(buildConfigUpper) ${{ parameters.archType }} displayName: Run tests in multifile mode - - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: - - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) --runnativeaottests $(buildConfigUpper) ${{ parameters.archType }} - displayName: Run tests diff --git a/src/tests/Common/CLRTest.Execute.Batch.targets b/src/tests/Common/CLRTest.Execute.Batch.targets index c7814fb342b5..77d9e59d576e 100644 --- a/src/tests/Common/CLRTest.Execute.Batch.targets +++ b/src/tests/Common/CLRTest.Execute.Batch.targets @@ -312,6 +312,11 @@ set CLRTestExitCode=!ERRORLEVEL! if defined RunCrossGen ( call :ReleaseLock ) +if defined RunNativeAot ( + if NOT "%CLRTestNoCleanup%" == "" ( + IF EXIST native rmdir /s /q native + ) +) $(BatchLinkerTestCleanupCmds) ]]> From c2e8be5b8c5a94c62d74697a56ffd1e15b57763c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 28 Sep 2020 09:34:22 +0200 Subject: [PATCH 3/8] Add missed tests --- src/tests/issues.targets | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 845dfc41c3c0..a2c0eba6a0ac 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1197,6 +1197,9 @@ Implement general purpose RuntimeHelpers.InitializeArray + + Implement general purpose RuntimeHelpers.InitializeArray + Throwing from a filter block @@ -1320,6 +1323,12 @@ Module constructors + + Module constructors + + + needs triage + Needs triage @@ -1344,6 +1353,9 @@ ReadyToRun tests + + needs triage + Disallow setting readonly static fields From 76f42ea1ef6b396b57083a7e5633c43779db38c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 28 Sep 2020 09:38:49 +0200 Subject: [PATCH 4/8] Optimized failures --- src/tests/issues.targets | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index a2c0eba6a0ac..52fd95ce4366 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1366,6 +1366,21 @@ EventPipe + + + Needs triage + + + Needs triage + + + Needs triage + + + Needs triage + + + From 15b105072bcdfb8d5f106e9c26b86856990862e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 28 Sep 2020 09:48:38 +0200 Subject: [PATCH 5/8] Update runtimelab-post-build-steps.yml --- eng/pipelines/runtimelab/runtimelab-post-build-steps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml index cf7bd373be92..6a813f085e3d 100644 --- a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml +++ b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml @@ -22,7 +22,7 @@ steps: displayName: Run tests in single file mode - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) --runnativeaottests $(buildConfigUpper) ${{ parameters.archType }} - displayName: Run tests in single file mode + displayName: Run tests in single file mode - ${{ if eq(parameters.osGroup, 'Windows_NT') }}: - script: $(Build.SourcesDirectory)/src/tests/run$(scriptExt) runnativeaottests nativeaotmultimodule $(buildConfigUpper) ${{ parameters.archType }} From 79830aa5a23ba5b2f4bd6251c85204efcdc2266f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 28 Sep 2020 16:01:49 +0200 Subject: [PATCH 6/8] Update issues.targets --- src/tests/issues.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 52fd95ce4366..0f42b08ab98e 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1367,7 +1367,7 @@ - + Needs triage From aa505d41d91171691cf7d9c07c2826037bb1387b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Thu, 1 Oct 2020 12:15:54 +0200 Subject: [PATCH 7/8] Review feedback --- eng/pipelines/runtimelab/coreclr-tests.yml | 6 ++---- eng/pipelines/runtimelab/runtimelab-post-build-steps.yml | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/eng/pipelines/runtimelab/coreclr-tests.yml b/eng/pipelines/runtimelab/coreclr-tests.yml index bf188c8bdfeb..55d648248532 100644 --- a/eng/pipelines/runtimelab/coreclr-tests.yml +++ b/eng/pipelines/runtimelab/coreclr-tests.yml @@ -1,7 +1,5 @@ trigger: none -pr: none - jobs: # # Checkout repository @@ -23,7 +21,7 @@ jobs: buildArgs: -s nativeaot+libs+installer -lc release -rc checked extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml extraStepsParameters: - smokeTestsOnly: 'false' + smokeTestsOnly: false runSingleFileTests: false @@ -42,5 +40,5 @@ jobs: buildArgs: -s nativeaot+libs+installer -c $(_BuildConfig) /p:ArchiveTests=true extraStepsTemplate: /eng/pipelines/runtimelab/runtimelab-post-build-steps.yml extraStepsParameters: - smokeTestsOnly: 'false' + smokeTestsOnly: false runSingleFileTests: false diff --git a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml index cf7bd373be92..3625b6568c70 100644 --- a/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml +++ b/eng/pipelines/runtimelab/runtimelab-post-build-steps.yml @@ -4,7 +4,7 @@ parameters: osGroup: '' osSubgroup: '' uploadTests: false - smokeTestsOnly: 'true' + smokeTestsOnly: true runSingleFileTests: true steps: From 8835887af2d7fa43e24b1d6986257d918145f37c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Thu, 1 Oct 2020 22:12:02 +0200 Subject: [PATCH 8/8] Update issues.targets --- src/tests/issues.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 0f42b08ab98e..e9e87bd039f6 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1200,6 +1200,9 @@ Implement general purpose RuntimeHelpers.InitializeArray + + Needs triage. Might be non-deterministic. Reproed without optimizations. + Throwing from a filter block