Fix memory leaks for return values and some out params. #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some memory leaks we had where we didn't generate code to free native resources for out parameters that use custom native type marshalling or all return values. Also set a flag in the csproj that enables a nice debugging innerloop option for roslyn components in the csproj settings (in our case running the generator on the integration tests)
jkoritzinsky
added
the
area-DllImportGenerator
|
Currently, we aren't doing a good job of testing the cleanup logic (I found this when inspecting codegen from #1197). With a specially-designed managed/native type pair, we can set something up to explicitly test that we free when expected, at least for the custom native type marshalling (the MarshalUsing scenario). For the other marshallers like the built-in string marshalling, our only testing is manual spot checks. That's one of the reasons I'd like to try moving more of the marshallers to be based on the custom native type marshalling and not directly in the stub if possible. #1197 and some follow-up work I have in a branch in my fork move us more in that direction. |
AaronRobinsonMSFT
approved these changes
Jun 3, 2021
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
…melab#1200) Fix some memory leaks we had where we didn't generate code to free native resources for out parameters that use custom native type marshalling or all return values. Also set a flag in the csproj that enables a nice debugging innerloop option for roslyn components in the csproj settings (in our case running the generator on the integration tests) Commit migrated from dotnet/runtimelab@b11a26a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some memory leaks we had where we didn't generate code to free native resources for out parameters that use custom native type marshalling or all return values.
Also set a flag in the csproj that enables a nice debugging innerloop option for roslyn components in the csproj settings (in our case running the generator on the integration tests)