Keep target DllImport info in structured data before converting to syntax. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
the
area-DllImportGenerator
This was referenced May 6, 2021
elinor-fung
approved these changes
May 7, 2021
AaronRobinsonMSFT
approved these changes
May 7, 2021
elinor-fung
reviewed
May 7, 2021
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
…ntax. (dotnet/runtimelab#1075) Commit migrated from dotnet/runtimelab@2f89e87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring helps simplify the solution for #1064, where we'll need to use this data to decide if we need to introduce a new DllImport-attributed target method due to differences in attribute data when the native signatures are identical.