Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Arcade 6.0.0-beta.21222.1 #1008

Merged

Conversation

elinor-fung
Copy link
Member

Update the Arcade version in feature/DllImportGenerator. Our branch is failing to publish its packages right now because we don't have the changes from the master->main rename

Set DNNE roll forward to Major. The Arcade update also bumped the SDK version used in the repo from 5.0 to 6.0.

First commit is simply from darc update-dependencies.
Second commit (DNNE roll forward) is the only thing I actually did.

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Apr 24, 2021
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@safern Any thing we should be concerned with moving up?

@elinor-fung elinor-fung merged commit cd7b25b into dotnet:feature/DllImportGenerator Apr 26, 2021
@elinor-fung elinor-fung deleted the updateArcade branch April 26, 2021 19:44
@safern
Copy link
Member

safern commented Apr 26, 2021

I don't think so. I would just look out for the official build after merging in case something changes (but it shouldn't have).

jkoritzinsky pushed a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
* Update to Arcade 6.0.0-beta.21222.1

* Set DNNE roll forward to Major so that we can build with 6.0 SDK

Commit migrated from dotnet/runtimelab@cd7b25b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants