Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: ARM64 SVE format encodings, SVE_BF_2A to SVE_FU_2A #98968

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Feb 27, 2024

Contributes to #94549

Adds formats:

  • SVE_BF_2A
  • SVE_FT_2A
  • SVE_FU_2A

These were tricky formats as the immediate is encoded as part of the element size. I added pretty exhaustive tests to ensure that this is correct.

Left: Capstone
Right: Jit
image
image
image

@ghost ghost assigned TIHan Feb 27, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 27, 2024
@TIHan TIHan added arm-sve Work related to arm64 SVE/SVE2 support and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 27, 2024
@TIHan
Copy link
Contributor Author

TIHan commented Feb 27, 2024

@dotnet/jit-contrib @dotnet/arm64-contrib @a74nh @amanasifkhalid this is ready.

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second Alan's comment on using insEncodeShiftImmediate in insEncodeSveElemsizeWithShift_tszh_tszl_imm3. Everything else LGTM, thanks!

@TIHan TIHan merged commit 8bdbf99 into dotnet:main Feb 27, 2024
124 of 129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants