JIT: ARM64 SVE format encodings, SVE_ID_2A to SVE_JH_2A
#98015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes to #94549 Adds 4 formats
This one is pretty short. Left: Capstone,
|
|
@dotnet/jit-contrib @dotnet/arm64-contrib @a74nh @kunalspathak this is ready, and it's a short one. |
Diff results for #98015Throughput diffsThroughput diffs for linux/arm64 ran on linux/x64Overall (+0.01%)
MinOpts (+0.01% to +0.02%)
FullOpts (+0.01%)
Details here |
a74nh
approved these changes
Feb 6, 2024
src/coreclr/jit/codegenarm64test.cpp
Outdated
|
|
||
| // IF_SVE_IE_2A | ||
| theEmitter->emitIns_R_R_I(INS_sve_ldr, EA_SCALABLE, REG_V3, REG_R4, 0, INS_OPTS_NONE, | ||
| INS_SCALABLE_OPTS_UNPREDICATED); // LDR <Zt>, [<Xn|SP>{, #<imm>, MUL VL}] |
There was a problem hiding this comment.
This isn't exactly the right use of INS_SCALABLE_OPTS_UNPREDICATED. Currently it's used where a predicate isn't being used to mask the result. Whereas here, the predicate is being used as the result.
But, once register allocation is added, we can get rid of INS_SCALABLE_OPTS_UNPREDICATED.
Therefore, I'm happy with this change.
There was a problem hiding this comment.
As per https://docsmirror.github.io/A64/2023-06/ldr_z_bi.html, this instruction is "unpredicated" and the use of INS_SCALABLE_OPTS_UNPREDICATED seems to be appropriate here, unless I am missing something.
kunalspathak
requested changes
Feb 7, 2024
src/coreclr/jit/codegenarm64test.cpp
Outdated
|
|
||
| // IF_SVE_IE_2A | ||
| theEmitter->emitIns_R_R_I(INS_sve_ldr, EA_SCALABLE, REG_V3, REG_R4, 0, INS_OPTS_NONE, | ||
| INS_SCALABLE_OPTS_UNPREDICATED); // LDR <Zt>, [<Xn|SP>{, #<imm>, MUL VL}] |
There was a problem hiding this comment.
As per https://docsmirror.github.io/A64/2023-06/ldr_z_bi.html, this instruction is "unpredicated" and the use of INS_SCALABLE_OPTS_UNPREDICATED seems to be appropriate here, unless I am missing something.
ghost
added
needs-author-action
|
@kunalspathak this is ready again. |
Diff results for #98015Throughput diffsThroughput diffs for linux/arm64 ran on linux/x64Overall (+0.01%)
MinOpts (+0.01% to +0.02%)
FullOpts (+0.01%)
Details here |
This was referenced Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #94549
Adds 4 formats
This one is pretty short.
Left: Capstone,
Right: Jit