Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Implement ThisPtrRetBufPrecode::Init #91451

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[RISC-V] Implement ThisPtrRetBufPrecode::Init #91451

merged 1 commit into from
Sep 4, 2023

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Sep 1, 2023

Fix "RISCV64: not implementation on riscv64!!!" assertion in corefx tests

System.Dynamic.Runtime.Tests
System.Linq.Queryable.Tests
Microsoft.CSharp.Tests

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @tomeksowi

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 1, 2023
@clamp03 clamp03 self-assigned this Sep 1, 2023
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Sep 1, 2023
This was referenced Sep 1, 2023
Closed
Closed
@clamp03 clamp03 marked this pull request as ready for review September 1, 2023 11:31
@clamp03 clamp03 requested a review from jkotas September 4, 2023 00:13
jkotas
jkotas approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jkotas jkotas merged commit 741ab87 into dotnet:main Sep 4, 2023
107 of 109 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2023
@clamp03 clamp03 deleted the ThisPtrRetBufPrecode branch October 24, 2023 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@alpencolt alpencolt alpencolt approved these changes

Assignees

@clamp03 clamp03

Labels
arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clamp03 @alpencolt @jkotas