Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify callback calling convention for callbacks on Windows x86 causes crashes on Mono. #89571

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Specify callback calling convention for callbacks on Windows x86 causes crashes on Mono. #89571

merged 5 commits into from
Aug 3, 2023

Commits on Jul 27, 2023

  1. Fix dotnet#88992. Explicit specify callback calling convention on Win… 

    …dows x86.

CoreCLR runtime get build using stdcall while Mono uses cdecl (default).
If a native runtime function takes a reverse pivnoke callback, this
difference will cause issues for Mono on Windows x86 since reverse
pinvoke callbacks have stdcall on Windows x86, but callbacks have
been prototyped to use the calling convention setup in build.

Since CoreCLR already uses stdcall on Windows x86 this change won't change
anything, while on Mono it will fixes the crashes observed in dotnet#8892.
    @lateralusX
    lateralusX committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    a3cf4b9 View commit details
    Browse the repository at this point in the history

  2. Re-enable tests previously disabled by dotnet#88992.

    @lateralusX
    lateralusX committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c2e3e93 View commit details
    Browse the repository at this point in the history

  3. Fix native EventPipe test to build and run under Windows x86.

    @lateralusX
    lateralusX committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1e73251 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Temporary only run windows x64/x86 mono outerloop tests.

    @lateralusX
    lateralusX committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    62a643c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Restore mono outerloop configuration.

    @lateralusX
    lateralusX committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    38e8360 View commit details
    Browse the repository at this point in the history