-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue references in ConvertToLibraryImportAnalyzerTests #89225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a directed test for function pointers and remove an outdated ActiveIssue
ghost
assigned jkoritzinsky
Jul 19, 2023
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsAdd a directed test for function pointers and remove an outdated ActiveIssue Fixes #71891
|
This was referenced Jul 20, 2023
jkoritzinsky
commented
Jul 25, 2023
...nteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
…rtGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
July 25, 2023 20:28
jtschuster
approved these changes
Jul 25, 2023
...nteropServices/tests/LibraryImportGenerator.UnitTests/ConvertToLibraryImportAnalyzerTests.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jul 25, 2023
Failure is unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a directed test for function pointers and remove an outdated ActiveIssue
Fixes #71891