From 4d48ba1de8ff3710904ca055ea5cc9c931b44c99 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 7 Jun 2023 15:40:44 -0400 Subject: [PATCH 1/3] [wasm] Fix running debugger tests on windows .. by making sure to escape `&` in the command line. This was introduced in: ``` commit e96321db982c3add192381f6ea4ff0a999ee1410 Author: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Tue Jun 6 05:59:43 2023 +0200 [wasm][debugger] Disable failing multithreading debugger tests (#86501) ``` .. but missed CI due to the helix outage. --- src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets index f28c4436f13a5..b486ffe13d0c6 100644 --- a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets +++ b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets @@ -27,7 +27,7 @@ $(TestArchiveTestsDir)Wasm.Debugger.Tests.zip $(HelixCommand) $(_DebuggerTestsWorkItemTimeout) - set "TEST_ARGS=--filter category!=failing&FullyQualifiedName~%(Identity)" + set "TEST_ARGS=--filter category!=failing^&FullyQualifiedName~%(Identity)" export "TEST_ARGS=--filter category!=failing&FullyQualifiedName~%(Identity)" From f706fa28d44c5eea5568730fdb0a51e4caea348c Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 7 Jun 2023 17:29:43 -0400 Subject: [PATCH 2/3] Fix escaping ! on windows --- src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets index b486ffe13d0c6..ffd65e64c3a9b 100644 --- a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets +++ b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets @@ -27,7 +27,7 @@ $(TestArchiveTestsDir)Wasm.Debugger.Tests.zip $(HelixCommand) $(_DebuggerTestsWorkItemTimeout) - set "TEST_ARGS=--filter category!=failing^&FullyQualifiedName~%(Identity)" + set "TEST_ARGS=--filter category^!=failing^&FullyQualifiedName~%(Identity)" export "TEST_ARGS=--filter category!=failing&FullyQualifiedName~%(Identity)" From c799f990e8549cef600e9c9f37630af145192183 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 7 Jun 2023 20:58:28 -0400 Subject: [PATCH 3/3] Try escaping again --- src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets index ffd65e64c3a9b..d9b1b8262e51a 100644 --- a/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets +++ b/src/mono/wasm/debugger/Wasm.Debugger.Tests/wasm.helix.targets @@ -27,7 +27,7 @@ $(TestArchiveTestsDir)Wasm.Debugger.Tests.zip $(HelixCommand) $(_DebuggerTestsWorkItemTimeout) - set "TEST_ARGS=--filter category^!=failing^&FullyQualifiedName~%(Identity)" + set "TEST_ARGS=--filter category^^!=failing^&FullyQualifiedName~%(Identity)" export "TEST_ARGS=--filter category!=failing&FullyQualifiedName~%(Identity)"