Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all of the net 6 packs to be labeled .net6 #73733

Merged

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Aug 11, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: marcpopMSFT
Assignees: marcpopMSFT
Labels:

area-Infrastructure-mono

Milestone: -

@lambdageek
Copy link
Member

@radical What needs to be fixed up in the WBT tests to use the updated pack names, if anything?

@lambdageek
Copy link
Member

Rolling back pack Microsoft.NET.Runtime.WebAssembly.Sdk.net6 installation...
/__w/1/s/src/libraries/workloads-testing.targets(127,5): error : Workload installation failed: microsoft.net.runtime.webassembly.sdk.net6::6.0.9 is not found in NuGet feeds [https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-1026ad55/nuget/v3/index.json;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json".](https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-1026ad55/nuget/v3/index.json;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json%22.) [/__w/1/s/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj]
##[error]src/libraries/workloads-testing.targets(127,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Workload installation failed: microsoft.net.runtime.webassembly.sdk.net6::6.0.9 is not found in NuGet feeds [https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-1026ad55/nuget/v3/index.json;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json".](https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-1026ad55/nuget/v3/index.json;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;/__w/1/s/artifacts/packages/Release/Shipping/;/__w/1/s/artifacts/packages/Release/NonShipping/;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json;https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/nuget/v3/index.json%22.)
  Exit code: 1

Does this mean we need to add a dotnet6 feed to some NuGet.config?

@radical
Copy link
Member

radical commented Aug 11, 2022

The generated package names need to be updated too.

@radical
Copy link
Member

radical commented Aug 11, 2022

I will add that, and test locally.

@radical
Copy link
Member

radical commented Aug 11, 2022

    "Microsoft.NETCore.App.Runtime.AOT.Cross.net6.browser-wasm": {
      "kind": "Sdk",
      "version": "${PackageVersion}",
      "alias-to": {
        "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm",
        "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm",
        "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm",
        "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm"
      }
    },

@marcpopMSFT Here, Microsoft.NETCore.App.Runtime.AOT.Cross.net6.browser-wasm is being mapped to packs without net6 in the name. Is that deliberate?

@radical
Copy link
Member

radical commented Aug 11, 2022

cc @jonathanpeppers @steveisok

@radical
Copy link
Member

radical commented Aug 11, 2022

It was able to install the workload now:

  ** Installing workload manifest wasm-tools **
  
  Installing workload manifest for Microsoft.NET.Workload.Mono.ToolChain/6.0.9 for sdk band 6.0.400
  Installing workload manifest for Microsoft.NET.Workload.Emscripten/6.0.8 for sdk band 6.0.400

Now, waiting on tests against that installed workload.

@radical
Copy link
Member

radical commented Aug 11, 2022

Wasm.Build.Tests are passing on Linux. Waiting on the windows ones.

@radical
Copy link
Member

radical commented Aug 11, 2022

Wasm.Build.Tests are passing on Linux. Waiting on the windows ones.

Oops, I forgot. We didn't have these tests running on windows for 6.0 .

@radical
Copy link
Member

radical commented Aug 12, 2022

The wasm/workload tests were run with SDK 6.0.400-rtm.22371.2, but the latest is 6.0.401. Should that be updated here?

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wasm workload tests ran successfully here. They used the new updated packs, and manifest. And they were run against dotnet-sdk-6.0.400-rtm.22371.2-linux-x64.

@hoyosjs hoyosjs merged commit 1301f62 into dotnet:release/6.0 Aug 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants