-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all of the net 6 packs to be labeled .net6 #73733
Update all of the net 6 packs to be labeled .net6 #73733
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @directhex Issue Detailsnull
|
@radical What needs to be fixed up in the WBT tests to use the updated pack names, if anything? |
Does this mean we need to add a dotnet6 feed to some NuGet.config? |
The generated package names need to be updated too. |
I will add that, and test locally. |
"Microsoft.NETCore.App.Runtime.AOT.Cross.net6.browser-wasm": {
"kind": "Sdk",
"version": "${PackageVersion}",
"alias-to": {
"win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm",
"linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm",
"osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm",
"osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm"
}
}, @marcpopMSFT Here, |
It was able to install the workload now:
Now, waiting on tests against that installed workload. |
Wasm.Build.Tests are passing on Linux. Waiting on the windows ones. |
Oops, I forgot. We didn't have these tests running on windows for 6.0 . |
The wasm/workload tests were run with SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wasm workload tests ran successfully here. They used the new updated packs, and manifest. And they were run against dotnet-sdk-6.0.400-rtm.22371.2-linux-x64
.
No description provided.