Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing regex position check after BOL optimization #66216

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Add missing regex position check after BOL optimization #66216

merged 2 commits into from
Mar 7, 2022

Conversation

stephentoub
Copy link
Member

Fixes #66212

@stephentoub stephentoub added this to the 7.0.0 milestone Mar 4, 2022
@stephentoub stephentoub requested a review from joperezr March 4, 2022 20:44
@ghost ghost assigned stephentoub Mar 4, 2022
@ghost
Copy link

ghost commented Mar 4, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66212

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: 7.0.0

joperezr
joperezr approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not that I expect it to make a difference, but should we add a test that is actually multi-line like "car\nbar\n" and has more than one match?

@stephentoub
Copy link
Member Author

Sure

@runfoapp runfoapp bot mentioned this pull request Mar 4, 2022
Closed
@stephentoub stephentoub merged commit 277e12b into dotnet:main Mar 7, 2022
@stephentoub stephentoub deleted the fixbolopt branch March 7, 2022 00:13
@stephentoub stephentoub mentioned this pull request Mar 15, 2022
Closed
@EgorBo
Copy link
Member

EgorBo commented Mar 17, 2022

Improvements on win-x64 dotnet/perf-autofiling-issues#3993

@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Regex Matches Count gives ArgumentOutOfRangeException (regression)
3 participants
@stephentoub @EgorBo @joperezr