Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RegexGenerator in System.Private.Xml #66142

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Use RegexGenerator in System.Private.Xml #66142

merged 1 commit into from
Mar 4, 2022

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 3, 2022 •
edited
Loading

Closes #62105 (I believe this is the only remaining place regexes are constructed from patterns known at compile time in libraries only targeting netcoreappcurrent).

@stephentoub stephentoub requested review from krwq and joperezr March 3, 2022 14:28
@ghost ghost assigned stephentoub Mar 3, 2022
@ghost
Copy link

ghost commented Mar 3, 2022

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Xml
Milestone: -

This was referenced Mar 3, 2022
Closed
Closed
danmoseley
danmoseley approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Clockwork-Muse
Copy link
Contributor

(I believe this is the only remaining place regexes are constructed from patterns known at compile time in libraries only targeting netcoreappcurrent).

I have a branch with ~10 changed libraries (or their tests), I just haven't had the chance to run all the tests since rebase before making the PR.

@stephentoub
Copy link
Member Author

I have a branch with ~10 changed libraries (or their tests)

Really? Which other libraries only build for netcoreappcurrent and have static patterns? I didn't see any, but I could have easily missed them. I've not looked at tests.

@danmoseley
Copy link
Member

Looks like there's ~10 ish in the tests that can be converted.

@Clockwork-Muse
Copy link
Contributor

Looks like only System.Private.DataContractSerialization, for libraries.

@Clockwork-Muse
Copy link
Contributor

I'll try to get the branch pushed tonight.

krwq
krwq approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please run outerloop tests before merging

@stephentoub
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@stephentoub
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub stephentoub merged commit 9053aa1 into dotnet:main Mar 4, 2022
@stephentoub stephentoub deleted the xmlregex branch March 4, 2022 11:33
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@krwq krwq krwq approved these changes

@StephenMolloy StephenMolloy StephenMolloy approved these changes

@joperezr joperezr joperezr approved these changes

@danmoseley danmoseley danmoseley approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Xml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start using the Regex source generator in this repo
7 participants
@stephentoub @Clockwork-Muse @danmoseley @krwq @am11 @joperezr @StephenMolloy